Specifying JSON modules #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
reviewed
May 8, 2020
| <p>The abstract operation ParseJSONModule takes a single argument _source_ which is a String representing the contents of a module.</p> | ||
|
|
||
| <emu-alg> | ||
| 1. Let _json_ be ? Call(%JSONParse%, *undefined*, « _source_ »). <!-- TODO: Refactor JSONParse into an abstract algorithm --> |
There was a problem hiding this comment.
Should the JSON be frozen? What if a developer accidentally call the json.arr.sort() then the file is corrupted
There was a problem hiding this comment.
Let's discuss this in a separate issue: https://github.com/tc39/proposal-module-attributes/issues/54
JLHwung
reviewed
May 8, 2020
| 1. Perform ! HostImportModuleDynamically(_referencingScriptOrModule_, _specifierString_, <ins>_attr_,</ins> _promiseCapability_). | ||
| 1. <ins>Let _argRef_ be the result of evaluating the second |AssignmentExpression|.</ins> | ||
| 1. <ins>Let _arg_ be ? GetValue(_argRef_).</ins> | ||
| 1. <ins>If _arg_ is *undefined*, let _attributes_ be *undefined*.</ins> |
There was a problem hiding this comment.
Note that this PR also fixes #52 .
There was a problem hiding this comment.
Good point, added to the commit message.
|
I'm going to land this PR; review comments still welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes #52