using the proper notation to use intrinsic from another realm #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caridy
commented
Mar 31, 2021
leobalter
approved these changes
Mar 31, 2021
Jack-Works
approved these changes
Apr 1, 2021
Co-authored-by: Jordan Harband <ljharb@gmail.com>
caridy
commented
Apr 1, 2021
spec.html
Outdated
| @@ -116,7 +116,7 @@ <h1>WrappedFunctionCreate ( _callerRealm_, _targetFunction_ )</h1> | |||
| 1. Assert: IsCallable(_targetFunction_) is *true*. | |||
| 1. Let _internalSlotsList_ be the internal slots listed in <emu-xref href="#table-internal-slots-of-wrapped-function-exotic-objects"></emu-xref>, plus [[Prototype]] and [[Extensible]]. | |||
| 1. Let _obj_ be ! MakeBasicObject(_internalSlotsList_). | |||
| 1. Set _obj_.[[Prototype]] to %Function.prototype% from _callerRealm_. | |||
| 1. Set _obj_.[[Prototype]] to _callerRealm_.[[Intrinsics]].[[*"%Function.prototype%"*]]. | |||
There was a problem hiding this comment.
@leobalter I don't think that's how 262 does it today, not need to use quotes or *, see AddRestrictedFunctionProperties algo.
There was a problem hiding this comment.
That's correct. I'll roll it back and merge as the original.
There was a problem hiding this comment.
hm, that seems like an oversight to me. i'll pursue updating it in 262.
There was a problem hiding this comment.
actually hm, i can see the logic here. since .[[foo]] is the string "foo" already, then .[[%Function.prototype%]] is the string "%Function.prototype%". thanks for finding that use case.
There was a problem hiding this comment.
@ljharb fyi, this syntax is used in 262 in a couple of places, see the following example:
<emu-clause id="sec-addrestrictedfunctionproperties" aoid="AddRestrictedFunctionProperties">
<h1>AddRestrictedFunctionProperties ( _F_, _realm_ )</h1>
<p>The abstract operation AddRestrictedFunctionProperties takes arguments _F_ (a function object) and _realm_ (a Realm Record). It performs the following steps when called:</p>
<emu-alg>
1. Assert: _realm_.[[Intrinsics]].[[%ThrowTypeError%]] exists and has been initialized.
This reverts commit 5f08771.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.