Switch back to a property on the exec result #14
Conversation
|
NOTE: This doesn't contain any changes in the README.md explainer for these semantics yet. |
|
hm, i'm not seeing a change that adds a property - only changes to Match Records? |
|
@ljharb: See https://github.com/tc39/proposal-regexp-match-offsets/pull/14/files#diff-077f5fffcbf5425dd54e0e582f70562dR62. The diff is not expanded by default. |
|
I plan to hold off on merging this PR and discussing this in committee. If there are no objections to the possible memory overhead resulting from going back to using a property, then I'll merge. |
|
Either I'm looking at the diff wrong, or I'm confused. The only substantive diffs I currently see are deleting "ToMatchOptions" and "FromMatchOptions" and replacing [[Capture]] by the triple [[StartIndex]], [[EndIndex]], and [[GroupName]]. |
|
@waldemarhorwat i was confused by the same thing; see #14 (comment) |
|
I think it's just GitHub being GitHub. |
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
|
Is there a way to see the an HTML version with the results of this PR? I can read through the diff, but it is still hard to follow. |
|
I can publish the spec to a subdirectory of docs/ in master, if that would help. |
|
I published it at https://tc39.es/proposal-regexp-match-offsets/pr/14/. |
Thanks. |
rbuckton
force-pushed
the
backToAProperty
branch
from
3cb3281
to
a4d8b89
Compare
# Conflicts: # docs/index.html # spec/sec-properties-of-the-regexp-prototype-object-patch.html # spec/sec-regexp-abstract-operations-patch.html
|
This option was agreed upon by the committee for advancement to Stage 3. |
This PR reverts back to having a property on the result from
RegExpBuiltinExecthat can be used to access indices similar to the Stage 1 proposal, as per the discussion in #12.