Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.0.151 Diff background remove issues #7

Closed
urielzen opened this issue Sep 12, 2019 · 8 comments
Closed

0.0.151 Diff background remove issues #7

urielzen opened this issue Sep 12, 2019 · 8 comments

Comments

@urielzen
Copy link

0.0.151 removed the background color to Diff window.
I believe that without the background color it is harder to identify where the new changes are happening.

image

Compare with original
image

Also the scrolling bar does not show where the changes are happening anymore.
now:
image

before:
image

@urielzen
Copy link
Author

bump

@chrisgbaker
Copy link

Definitely still an issue. It's caused me to pick a different theme until this is fixed, as it makes the diff tool very cumbersome, especially the lack of the sidebar.

@chrisgbaker
Copy link

In reading the docs, i believe this is an easy fix:
image
I believe this theme is specifying both, which may be messing this up now. Not sure if this is a new change to how VSCode applies themes.

@urielzen
Copy link
Author

urielzen commented Oct 4, 2019

@chrisgbaker fortunately there is an option in vscode to install a previous version so you dont have to switch themes.

image

@chrisgbaker
Copy link

@urielzen thanks! I wasn’t sure if that would work or if it was due to a change in vscode, but I’ll try that tomorrow

@tcd
Copy link
Owner

tcd commented Nov 6, 2019

Hey @urielzen and all,

Sorry I didn't see this earlier. I'll look into this asap, thank you for bringing it to my attention.
Will post progress back to this issue.

Thanks,
Clay

@tcd
Copy link
Owner

tcd commented Nov 7, 2019

@urielzen @chrisgbaker y'all take a look at the highlighting in 0.0.154 and let me know if there are still any issues.

@urielzen
Copy link
Author

urielzen commented Nov 7, 2019

Thanks, it works great with the latest version!

@urielzen urielzen closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants