Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Clone to Timestamp and Date types #700

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Adding Clone to Timestamp and Date types #700

merged 3 commits into from
Sep 22, 2022

Conversation

jsaied99
Copy link
Contributor

Adding Clone to the traits of pgx::Timestamp.

workingjubilee
workingjubilee requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this! Yeah, any simple values like this one should be at least Clone. Probably Copy, honestly. Can you make sure all of the Date and Time* types implement Clone?

workingjubilee
workingjubilee approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@workingjubilee workingjubilee changed the title Adding Clone trait to pgx::Timestamp object Adding Clone to Timestamp and Date types Sep 22, 2022
@workingjubilee workingjubilee merged commit 5fe0b33 into pgcentralfoundation:develop Sep 22, 2022
@sumerman sumerman mentioned this pull request Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsaied99 @workingjubilee