Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Support weight and height fields #28

Open
1 of 5 tasks
Tracked by #45
Aviortheking opened this issue Jun 5, 2021 · 1 comment
Open
1 of 5 tasks
Tracked by #45

enhancement: Support weight and height fields #28

Aviortheking opened this issue Jun 5, 2021 · 1 comment
Labels
database Card Datas Related enhancement New feature or request
Projects
Milestone

Comments

@Aviortheking
Copy link
Member

Aviortheking commented Jun 5, 2021

Data affected

  • Card
  • Set
  • Serie
  • Other
  • new Data Type

Please explain in more details what idea you have

Currently each cards have a Pokémon Weight and Height.

idk how to put this in the database and how to transform it in the distribution base.

ex:

a float in KG in the db and the dist show and object with each thingy

OR

the API show the internationnal format and each SDKs have helper function to translate it to another format

@Aviortheking Aviortheking added database Card Datas Related enhancement New feature or request labels Jun 5, 2021
@Aviortheking Aviortheking added this to the 2.0 milestone Jun 5, 2021
@Aviortheking
Copy link
Member Author

Aviortheking commented Aug 22, 2021

Weight is rounded to the first decimal, ex: if we use KGs as the base 84.4kg will translate to 190.5lbs

Height is in Feet and Inch for the english one and Meter for the others, ex: 1m ===3'03" or 3feet and 3inch

two solutions:

  1. Make the fields include both values (only the distribution, the db would use international values)
  2. Make methods on the SDKs to translate from the international KG and Meter to the lbs and feet

@Aviortheking Aviortheking added this to Backlog in Project Sep 30, 2021
@Aviortheking Aviortheking changed the title Support Weight and Height [Up]: Support Weight and Height fields Oct 7, 2021
@Aviortheking Aviortheking changed the title [Up]: Support Weight and Height fields [Up]: Support weight and height fields Oct 18, 2021
@Aviortheking Aviortheking changed the title [Up]: Support weight and height fields enhancement: Support weight and height fields Feb 14, 2022
@Aviortheking Aviortheking mentioned this issue May 7, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database Card Datas Related enhancement New feature or request
Projects
No open projects
Project
  
Backlog
Development

No branches or pull requests

1 participant