Rails 3.1 Support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ActiveRecord::Base.
chained and current_shard is available as instance var.
Migrations use ActiveRecord::Base.connection_pool which should be aware of current_shard context. Also, when connections get removed Octopus still retains reference to closed connection pool. For now, make sure we are able to automatically recreate connections, which is what would happen in Rails 3.0
…ized on load. Makes Octopus.find more performant
heavily nested operations.
|
Seems fine to me. @tchandy, ping? |
|
amazing! I need to review the failing spec, but will merge ASAP. Thanks for your work! |
…ely for deeply nested access patterns
|
Let me know if I can help in any way. :-) Also, last two commits were meant for a separate branch I was playing with, so ignore accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes help get Octopus almost fully across the Rails 3.1 support finish line.
Only a couple of specs don't pass, but they're pretty minor and the problems look to be with the specs rather than Octopus functionality.