Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Sentry analytics - reuse Matomo #799

Open
NicolasBuquet opened this issue Mar 30, 2023 · 0 comments
Open

Disable Sentry analytics - reuse Matomo #799

NicolasBuquet opened this issue Mar 30, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request iOS

Comments

@NicolasBuquet
Copy link
Contributor

NicolasBuquet commented Mar 30, 2023

Sentry framework is actually embedded in the application by Riot modules.

It is not instantiated nor used by default because it is dependent on a setting RiotSettings.shared.enableAnalytics.

The method RiotNSE/NotificationService:setupAnalytics() is called when receiving a notification.
It calls setupAnalytics() which calls analytics.startIfEnabled().
It fires Analytics which instantiates SentryMonitoringClient() but if, and only if RiotSettings.shared.enableAnalytics is TRUE.

RiotSettings.shared.enableAnalytics is linked to an option in the application's settings :
IMG_7083

This option is set to FALSE by default.

The proposal is to hide this option in settings and to force RiotSettings.shared.enableAnalytics to FALSE too.

PostHog is also used in the application in place of Matomo since november 2022 : element-hq/element-ios#5035

PostHog must be removed too.

@NicolasBuquet NicolasBuquet added enhancement New feature or request iOS labels Mar 30, 2023
@NicolasBuquet NicolasBuquet self-assigned this Mar 30, 2023
@NicolasBuquet NicolasBuquet changed the title Disable Sentry analytics Disable Sentry analytics - reuse Matomo Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iOS
Projects
None yet
Development

No branches or pull requests

1 participant