Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite by email : Trigger duplicate DM with the same user #79

Closed
estellecomment opened this issue Jun 28, 2022 · 9 comments
Closed

Invite by email : Trigger duplicate DM with the same user #79

estellecomment opened this issue Jun 28, 2022 · 9 comments

Comments

@estellecomment
Copy link
Contributor

estellecomment commented Jun 28, 2022

At least one broken feature :

  • Create a DM with an existing user.
  • Create another DM with the same user, by email
  • the 2nd DM is created. The user is properly displayed (the matrixID has been found). You now have two identical DMs with the same person.

Why is this happening ? The Identity Server should be doing the lookup of the email, to find the corresponding matrixId. It doesn't do it because we have not configured the IS (does the client know the url of the IS server ?) and we have not trusted it (accepted the terms and conditions). This is the "discovery" feature.

Find what other features using by email are broken.

More information on : element-hq/element-web#23353

@estellecomment
Copy link
Contributor Author

Do we have this in v2?

@giomfo
Copy link

giomfo commented Jul 6, 2022

Do we have this in v2?

No, because "lookup" request is supported in v2
This is related to the "Discovery" option : we should trust by default the id serveur imposed by Tchap HS (the TAC included this id server use). We were thinking about a change in server side to trust it by default on account creation

@estellecomment
Copy link
Contributor Author

Note : if it's simpler, we could consider just disabling invitation by email in the beta...

@estellecomment
Copy link
Contributor Author

@giomfo : the user with which I have created the double DM (as described above) should already have discovery working : it's a user created in tchap v2.
So I'm not sure why tartine is doing this. 🤔

@estellecomment
Copy link
Contributor Author

estellecomment commented Jul 18, 2022

  • Confirm : when you start a DM by email, there is custom code in tchap v2 that looks up the matrixId, and directs the user to the pre-existing DM with this matrixID. This avoids creating two parallel DMs.
  • Should Tchap keep this custom feature ?
  • If yes, how do we reimplement it in Tartine ?

@estellecomment
Copy link
Contributor Author

Note : for beta bucheron, we only deal with users who have a previously created account. So accepting discovery is already done.
(but it doesn't solve this problem)

@estellecomment
Copy link
Contributor Author

Note : this could be present in element, or not. Investigate to clarify the issue.

@mcalinghee mcalinghee added P2 Priority 2 and removed P1 Priority 1 labels Sep 22, 2022
@giomfo
Copy link

giomfo commented Sep 26, 2022

Note : this could be present in element, or not. Investigate to clarify the issue.

I reproduced the issue in Element-Web. No lookup is triggered on client side. I created element-hq/element-web#23353

@mcalinghee mcalinghee self-assigned this Oct 12, 2022
@mcalinghee mcalinghee changed the title Inviting by email is (partially?) broken Duplicate DM with the same user when inviting by email Oct 12, 2022
@mcalinghee mcalinghee changed the title Duplicate DM with the same user when inviting by email Invite by email : Trigger duplicate DM with the same user Oct 12, 2022
@mcalinghee mcalinghee removed their assignment Oct 17, 2022
@odelcroi odelcroi removed the P1 Priority 1 label Oct 26, 2022
@giomfo
Copy link

giomfo commented Feb 17, 2023

FYI element-hq/element-web#23353 has been fixed
Those will be included in the next release 1.11.24

@odelcroi odelcroi closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants