UX : "New Recovery Method" dialog does not cover the most common case (it was not an attacker, it was me on mobile)

[estellecomment]

When I create a new recovery code on mobile, I see this dialog on web :

I don't know what to do next : it was not an attacker, it was me. This is the most common use case (users are rarely attacked for real)

• I need info : Is there anything I should do, or is everything ok ?
• Where do I click to make this go away ?

---

For dev : also need to understand :

• does this dialog show up every time I create a new recovery code? (@NicolasBuquet saw it while debugging a messed up session, what happens in a normal case?)
• what does the primary button actually do?

[estellecomment]

does this dialog show up every time I create a new recovery code?

No.

When does it show up then ?
In https://github.com/matrix-org/matrix-react-sdk/blob/81c62e51c474581c3d3f0f1e72aa0d1eb26ac45a/src/components/structures/MatrixChat.tsx#L1688..L1711
NewRecoveryMethodDialog is created when cli.on(CryptoEvent.KeyBackupFailed), in the case where there is another keybackup detected.

When I'm in the process of recreating a code, but another client recreates a code ?

[estellecomment]

Could not reproduce in 3 tries.
This is a rare enough case that it's fine to have a bad UX on it. Closing.