New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In TagDeserializer.java, when the code is "nonce", both nodeNonce and nodeDifficulty are set to node.get(1). #69

Closed

Memory-of-Snow opened this issue Jul 11, 2023 · 1 comment

Assignees

Contributor

Memory-of-Snow commented Jul 11, 2023

Describe the bug
In TagDeserializer.java, when the code is "nonce", both nodeNonce and nodeDifficulty are set to node.get(1).

Expected behavior
Most likely, nodeDifficulty should reference node.get(2).

Additional context
Does nonce fit within the range of an Integer data type? Is it possible for larger numbers to be included?

Memory-of-Snow mentioned this issue

in case "nonce",change nodeDifficulty from node.get(1) to node.get(2) #70

Merged

tcheeric self-assigned this

Owner

tcheeric commented Mar 24, 2024

This has been merged already.

tcheeric closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment