Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider changing TestSubscriber.sequence to something else #5

Closed
heckj opened this issue Jul 16, 2019 · 3 comments
Closed

consider changing TestSubscriber.sequence to something else #5

heckj opened this issue Jul 16, 2019 · 3 comments

Comments

@heckj
Copy link
Contributor

heckj commented Jul 16, 2019

In using TestSubscriber, I found the property name sequence to be confusing. While it makes sense in the framing of what's been collection, and that it's an ordered list, I immediately confused it for Combine's Sequence.

I wanted to suggest that perhaps a different name would be easier to work with - although I'm lacking on brilliant ideas. My fogged brain only really came up with results or orderedResults as alternative property names.

@tcldr
Copy link
Owner

tcldr commented Jul 17, 2019

Yeah, I can see that. How about sequenceOutput? A publisher already has its associated Output type, so hopefully that ties things together with more clarity.

@heckj
Copy link
Contributor Author

heckj commented Jul 18, 2019

yeah, sequenceOutput seems very reasonable. In working with it a bit more today, I realized that I also would love to be able to test the data collected by the testable subscriber separate from the control messages. It's not hard to filter manually (once you clue in the subscribe and completions are listed as well), but it might be worth considering as well

@tcldr
Copy link
Owner

tcldr commented Jul 19, 2019

In the end I went with recordedOutput as that way it pairs nicely with recordedDemandLog. Thanks for the suggestions! Released in v0.6.0.

@tcldr tcldr closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants