Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge lines in POV output reportedly generate an invalid POV file #81

Open
tcobbs opened this issue Mar 13, 2024 · 1 comment
Open

Edge lines in POV output reportedly generate an invalid POV file #81

tcobbs opened this issue Mar 13, 2024 · 1 comment
Assignees

Comments

@tcobbs
Copy link
Owner

tcobbs commented Mar 13, 2024

Describe the bug
According to Steffen, exporting edge lines to POV generates a syntax error in the POV:

https://forums.ldraw.org/thread-28148-post-53424.html#pid53424

@MinnieTheMoocher
Copy link

MinnieTheMoocher commented Mar 13, 2024

Hi Travis, here is a small demo for the problem:

  • test.ldr is a small LDRAW scene, export it with LDView 4.5 with edges and cond edges export to POVRay enabled
  • result is the test.pov file containing the syntax error
  • I corrected the file by hand, the result is test_corrected.pov

The 4 manual corrections which I did are as follows:

  • removed stray #end line (syntax error)
  • wrapped the declaration of LDXEdges by #if (LDXSkipEdges = 0) ... #end because it otherwise takes HUGE parsing time in real-world scenes (which are MUCH larger than test.ldr)
  • wrapped the declaration of LDXConditionalEdges by #if (LDXSkipEdges = 0) ... #end because it otherwise takes HUGE parsing time in real-world scenes (which are MUCH larger than test.ldr)
  • corrected the #if logic:
#if (LDXSkipEdges = 0)
	object { LDXEdges }
	object { LDXConditionalEdges }
#end

I'd like to suggest to takeover these into LDView.

test.zip

@tcobbs tcobbs self-assigned this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants