Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up fetchall/limit/slice interface #281

Closed
tconbeer opened this issue Oct 12, 2023 · 0 comments · Fixed by #322
Closed

Clean up fetchall/limit/slice interface #281

tconbeer opened this issue Oct 12, 2023 · 0 comments · Fixed by #322
Labels
refactor

Comments

@tconbeer
Copy link
Owner

We need to:

  1. Apply a limit if it's set in the UI
  2. Give an accurate rowcount for the results, even if that is more than we want to load into the data table
  3. Only load max_results into the data table.

I think maybe (3) could be handled when initializing the data table backend, since each data type can get pruned in its own way.

For (1), we use DuckDB's relational api, but for the other dbs we can probably just use fetchmany(limit) instead of fetchall()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: clean up fetchall slice interface tconbeer/harlequin
1 participant
@tconbeer