Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config file discovery #471

Closed
tconbeer opened this issue Feb 20, 2024 · 0 comments · Fixed by #473
Closed

Improve config file discovery #471

tconbeer opened this issue Feb 20, 2024 · 0 comments · Fixed by #473
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tconbeer
Copy link
Owner

tconbeer commented Feb 20, 2024

See #466

We should default to the XDG Standard on unix systems; platformdirs has an implementation as user_config_dir (or user_config_path). This defaults to the same ~/.config, but can be overridden by $XDG_CONFIG_DIR var. Default in that dir should be harlequin.toml (no dot). Should find .harlequin.toml or harlequin.toml in the cwd.

This should be communicated as a potentially-breaking change.

Docs will have to be updated:

https://github.com/tconbeer/harlequin-web/blob/48eab9d990f39912e67a2d301aa6b101d4bbc02e/src/docs/config-file.md?plain=1#L14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant