Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check the same URL multiple times #111

Closed
chriselion opened this issue Sep 25, 2020 · 2 comments
Closed

Don't check the same URL multiple times #111

chriselion opened this issue Sep 25, 2020 · 2 comments
Labels
enhancement New feature request or implementation

Comments

@chriselion
Copy link

Following up from a comment

If the same URL appears twice in a file, you can cache the results of the first check and not check it again.

Ideally if we could pass multiple files at once, this caching would persist across files.

@NicolasMassart NicolasMassart added the enhancement New feature request or implementation label Sep 26, 2020
@NicolasMassart NicolasMassart changed the title [feature request] Don't check the same URL multiple times Don't check the same URL multiple times Oct 1, 2020
@NicolasMassart NicolasMassart added this to Low priority in Issues progress Nov 6, 2020
@sanmai-NL
Copy link

The initial solution can be simple and without persistent caching: keep a dictionary/mapping URL -> status outside the file loop.

@tcort
Copy link
Owner

tcort commented Mar 9, 2023

There's an open task for this link-check issue #31. Feel free to implement it and submit a PR. It'd be a nice feature to have.

@tcort tcort closed this as completed Mar 9, 2023
Issues progress automation moved this from Low priority to Done Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or implementation
Projects
Development

No branches or pull requests

4 participants