Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gemfile.lock #22

Merged
merged 2 commits into from May 26, 2015
Merged

Conversation

ms-ati
Copy link
Contributor

@ms-ati ms-ati commented Apr 6, 2015

A gem should not commit Gemfile.lock. In this case,
a stale dependency on json 1.7.5 was breaking my
bundle install on ruby 2.2.1, due to the version
incompatibility.

For more information on this, please see:
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
radar/guides#14
TenjinInc/dirt-core#1

A gem should not commit Gemfile.lock. In this case,
a stale dependency on json 1.7.5 was breaking my
`bundle install` on ruby 2.2.1, due to the version
incompatibility.

For more information on this, please see:
http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/
radar/guides#14
TenjinInc/dirt-core#1
@ms-ati
Copy link
Contributor Author

ms-ati commented May 26, 2015

Hi Tom, did you have any thoughts on this?

@ms-ati
Copy link
Contributor Author

ms-ati commented May 26, 2015

(Just to add, this one is really annoying as the current Gemfile.lock is broken on recent ruby versions.)

tcrayford added a commit that referenced this pull request May 26, 2015
@tcrayford tcrayford merged commit 145317d into tcrayford:master May 26, 2015
@ms-ati ms-ati deleted the remove-gemfile-lock branch June 9, 2015 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants