Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect values in arrows kata #20

Closed
walterlatimer opened this issue Sep 8, 2015 · 3 comments · Fixed by #21
Closed

Incorrect values in arrows kata #20

walterlatimer opened this issue Sep 8, 2015 · 3 comments · Fixed by #21

Comments

@walterlatimer
Copy link
Contributor

  it('one parameter can be written without parens', () => {
    var func = p => param - 1;
    assert.equal(func(23), 24);
  });

Pretty sure func(23) should be func(25).

@wolframkriesing
Copy link
Collaborator

Hi Walter,

actually the second line can be changed too, so there is no need to adjust the assert-line.
the function may also become var func = param => param + 1; is one way

@walterlatimer
Copy link
Contributor Author

Hi Wolfram!

While true, that isn't the point of the kata, which is to understand how arrows work.

@wolframkriesing
Copy link
Collaborator

as you can see here walterlatimer@4adb956 I intentionally changed it, since I develop the katas so that they pass first, but will merge the attached PR now, since I agree on your point ... thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants