Error accessing request.promster.start in hapi

[2color]

Describe the bug

• Error accessing the start in the request callback: https://github.com/tdeekens/promster/blob/master/packages/hapi/modules/plugin/plugin.js#L49

To Reproduce
Steps to reproduce the behavior:

1. Given a server as follows:

  import { createPlugin } from '@promster/hapi'
  import { createServer as createMetricsServer } from '@promster/server'
  import Hapi from '@hapi/hapi'

  const server = Hapi.server({
    port: 4000,
    host: process.env.HOST,
  })

  await server.register(createPlugin())

  server.route({
    method: 'GET',
    path: '/',
    handler: (request, h) => {
      return 'hello!'
    }
  })

  await server.start()
  console.log('Server running on %s', server.info.uri)

  await createMetricsServer({ port: 4001 })
  console.log(`@promster/server started on port ${process.env.METRICS_PORT}.`)

  await server.register(createPlugin())

2. Then 'curl localhost:4000'

TypeError: Cannot read property 'start' of undefined
    at Object.onResponseHandler [as listener] (/...../myserver/node_modules/@promster/hapi/modules/plugin/plugin.js:54:40)

Expected behavior

• No error and request.promster available in onResponseHandler

Additional context

• Running:

  • hapi.js 18.3.1
  • @promster/hapi 2.2.4
  • @promster/server 2.1.1

• According to the docs the request-event callback uses the function(request, event, tags) signature rather than (request, h) => {} as in

  promster/packages/hapi/modules/plugin/plugin.js

  Line 48 in 47a4f1d

  const onRequestHandler = (request, h) => {

  .

• According to the docs the request.plugins is the place to set things like the promster object:

Plugin-specific state. Provides a place to store and pass request-level plugin data. The

• Strangely, when debugging, the onRequestHandler wouldn't get called on incoming requests.

[tdeekens]

Thanks for the very nice but report and sorry for the inconvienence. I will try to look into this as soon as I find time.

[tdeekens]

Turns on server.events.on('request') is only invoked when logging before. There is a GitHub issue where people got confused. Loads of the other internal events are not supported anymore. I went back to use server.ext tested it locally and will publish soon.

[tdeekens]

Published @promster/hapi@2.2.5 and tested it locally. Please re-test and feel free to re-open in case it's not solved. Thanks again.

[2color]

Thanks. Works like a breeze