Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NodeJS url module instead of deprecated transitive dependency #845

Closed
dhs3000 opened this issue Jan 21, 2022 · 3 comments
Closed

Use NodeJS url module instead of deprecated transitive dependency #845

dhs3000 opened this issue Jan 21, 2022 · 3 comments

Comments

@dhs3000
Copy link
Contributor

dhs3000 commented Jan 21, 2022

Describe the bug
I get the following warning when using promster:

npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

This is due to promster/metrics using the (external) url package. NodeJS provides the same functionality which was deprecated for some time, but that has been revoked.

To Reproduce
Steps to reproduce the behavior:

  1. Add promster to a project, for example "@promster/express"
  2. Run npm. install
  3. See the printed warning
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.

Expected behavior
No deprecation warnings when using promster.

Additional context

  • I tried to create a pull request and remove the dependency, but cannot get commitizen / the pre-commit hook to work
  • The tests still run when just removing the dependency from metrics/package.json
  • I used Node 16 (LTS)
@tdeekens
Copy link
Owner

Thanks for opening an issue. You could try to commit with --no-verify to skip commit checks if they're bothering you.

@tdeekens
Copy link
Owner

@dhs3000 the fix has been released. Enjoy. Thanks for your contribution.

@dhs3000
Copy link
Contributor Author

dhs3000 commented Jan 21, 2022

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants