Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPromsterOptions incorrect property #888

Closed
gimerstedt opened this issue Mar 22, 2022 · 2 comments
Closed

TPromsterOptions incorrect property #888

gimerstedt opened this issue Mar 22, 2022 · 2 comments

Comments

@gimerstedt
Copy link

gimerstedt commented Mar 22, 2022

Describe the bug
I did not deep-dive here but it looks like the property "buckets" on TPromsterOptions in the typings package might have the incorrect type. Should it not be number[] or Array<number> as opposed to [number]?

https://github.com/tdeekens/promster/blob/main/packages/types/src/index.ts#L20

https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgILIN4Chm+XALmQG0QBXAWwCNoBdHPKo866Y+vZBI1KKOAJ4AeFjSgA+LAF8sWBAHsQAZzD4eyALyYGuQiQCMAGgBMhgMy1DO5EwMnzl69zumL0oA

To Reproduce
Steps to reproduce the behavior:

  1. Given '...'
  2. Then '....'
  3. That '....'

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@tdeekens
Copy link
Owner

Thanks for opening an issue.

I think you're absolutely correct. those properties should be an number[] and not a list of one element with a number.

Would you mind opening a PR with a fix? You can add a changeset on the PR and we could get a fix out soon.

@tdeekens
Copy link
Owner

Will be released in next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants