Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Map.forEachFeatureAtPixel #96

Closed
gkresic opened this issue Jul 18, 2017 · 1 comment
Closed

Customizable Map.forEachFeatureAtPixel #96

gkresic opened this issue Jul 18, 2017 · 1 comment
Milestone

Comments

@gkresic
Copy link
Contributor

gkresic commented Jul 18, 2017

Map.forEachFeatureAtPixel should have additional prototype with FeatureAtPixelOptions for customizations.

Will provide a patch soon.

Unrelated to this issue, I would like to ask @TDesjardins if this workflow "file an issue" -> "provide a patch" is valid? I looks like there are considerable amount of missing features in gwt-ol3 (which is completely understandable) so I'll have to spam this project a bit. I could pack several improvements in one pull request, but then I risk that because of one misimplemented feature whole pull request gets rejected. Note that I don't mind filing an issue for each feature implemented, I'm just asking if that is OK with maintainer.

@TDesjardins
Copy link
Owner

@gkresic Please provide pull requests by feature! If you pack several improvements in one pull request the review is not possible. It's not neccessary to open an issue, but this maybe saves you from wasting your time (e.g double implementation or an existing feature). It isn't spam it's communication ;-)

TDesjardins added a commit that referenced this issue Jul 18, 2017
Configurable Map::forEachFeatureAtPixel
@TDesjardins TDesjardins added this to the v4.0.0 milestone Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants