Improved navigation interface, added next() method #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller improvement of the
org.odftoolkit.odfdom.incubator.search.Navigation
Interface.Using this feature in my own project I recognized that the
TextNavigation
was not working correctly - especially in case the search pattern occur multiple times in one document or paragraph.The following example shows how to replace all matches of a regex with a text using the new implementation:
The method
TextNavigation.next()
is new and a convenient method forgetCurrentItem().getElement();
An important bugfix is in the method
setCurrentTextAndGetIndex
. This method runs in a outOfBounds Exception in case the pattern length was equals to the replacement text length. This is now also fixed.I have tested the new code in my own project and it works now perfect - even with text in embedded table cells.