New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move geom-* specific code to geom-*.R class definition #44
Conversation
…ecific geom classes
Hi @tdhock, I've made some changes, can you review, please? |
the design looks more reasonable. so you have export_animint in the main Geom, which calls geom-specific pre_process methods? |
Yes right! Please let me know if you want me to close this PR and create a new one on the master branch. |
can you please close this PR, then open a new PR from tdhock:geom-oop to tdhock:master
|
I got it! I'll do this! |
So far I've moved the following geom class definitions: