Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move geom-* specific code to geom-*.R class definition #44

Closed
wants to merge 9 commits into from

Conversation

lazycipher
Copy link
Collaborator

So far I've moved the following geom class definitions:

  • abline
  • point
  • text
  • ribbon
  • bar
  • violin, etc

@lazycipher
Copy link
Collaborator Author

Hi @tdhock, I've made some changes, can you review, please?

R/geom-contour.r Outdated Show resolved Hide resolved
@tdhock
Copy link
Collaborator

tdhock commented Aug 14, 2020

the design looks more reasonable. so you have export_animint in the main Geom, which calls geom-specific pre_process methods?
why is the build failing?
why do you want to merge into r4-fixes? shouldn't you merge into master?

@lazycipher
Copy link
Collaborator Author

Yes right!
The build is failing because of that gist test.
Actually I thought I should be working on this branch and then merge to r-4-fixes and when you'll be back, we'll have just to merge r-4 fixes to master.

Please let me know if you want me to close this PR and create a new one on the master branch.

@tdhock
Copy link
Collaborator

tdhock commented Aug 14, 2020

can you please close this PR, then open a new PR from tdhock:geom-oop to tdhock:master

  • creating the branch in tdhock repo should resolve the gist fail issue
  • merging to master is what you should do in almost every PR

@lazycipher
Copy link
Collaborator Author

I got it! I'll do this!
Thank you so much!

@lazycipher lazycipher closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants