Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various Dockerfile fixes and enhancements #13

Merged
merged 4 commits into from
Nov 25, 2020
Merged

Various Dockerfile fixes and enhancements #13

merged 4 commits into from
Nov 25, 2020

Conversation

matteob99
Copy link

Fix Dockerfile

  • log default to stdin
  • added to readme istruction to use with docker
  • fix user permission

@MarcoBuster MarcoBuster added the enhancement New feature or request label Nov 24, 2020
@MarcoBuster MarcoBuster changed the title Fix Dockerfile Various Dockerfile fixes and enhancements Nov 24, 2020
MarcoBuster
MarcoBuster requested changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@MarcoBuster MarcoBuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. Next time use a more descriptive title, please.

README.md Outdated
@@ -108,7 +108,12 @@ In addition, the member list now shows the full bot list (previously only the bo
<a name="installation"></a>
## Installation

The simplest way to build and install `Telegram Bot API server` is to use our [Telegram Bot API server build instructions generator](https://tdlib.github.io/telegram-bot-api/build.html).
The simplest way is using docker with this command:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "The simplest way to use it is with this docker command" it's better.

MarcoBuster
MarcoBuster approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@MarcoBuster MarcoBuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please do not merge until the CI has finished successfully.

@MarcoBuster MarcoBuster merged commit 19c38c6 into tdlight-team:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoBuster MarcoBuster MarcoBuster approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matteob99 @MarcoBuster