Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More docs improvements. #23

Merged
merged 3 commits into from
Dec 12, 2020

Conversation

luckydonald
Copy link
Collaborator

No description provided.

@giuseppeM99 giuseppeM99 added the documentation Improvements or additions to documentation label Dec 11, 2020
Copy link
Collaborator

@giuseppeM99 giuseppeM99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use API Methods instead of API Commands to stay in line with the official documentation.
Also change max-batch-operations to --max-batch-operations to match the edits on the other executable parameters

@giuseppeM99
Copy link
Collaborator

LGFM

Copy link
Collaborator

@MarcoBuster MarcoBuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Every new command line parameter has a environment variable (like --insecure has TELEGRAM_INSECURE), you can find the complete list here. It would be nice to document them all in a way you can immediately catch what environment variable is associated to a command line paramater, because most of us use Docker.

@luckydonald
Copy link
Collaborator Author

@MarcoBuster, yes we should do that in the future.
For now this should clean up what's there, mostly.

@MarcoBuster
Copy link
Collaborator

@MarcoBuster, yes we should do that in the future.
For now this should clean up what's there, mostly.

Ok. #14 contains some ideas about the future of documentation for this project.

@MarcoBuster MarcoBuster merged commit 0edac66 into tdlight-team:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants