Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camelCase of userLogin in the docs. #43

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

luckydonald
Copy link
Collaborator

No description provided.

@luckydonald luckydonald changed the title Fix camelCase of userLogin. Fix camelCase of userLogin in the docs. Jan 6, 2021
@spontanurlaub
Copy link
Collaborator

@luckydonald No, only userlogin in lowercase works. The case is usually ignored, but this is a special method where this is not possible. Please have a look at the respective code.

@luckydonald
Copy link
Collaborator Author

luckydonald commented Jan 7, 2021

In that case it should be changed in the code to be camelCase IMO. It really doesn't make sense to have a single endpoint work differently to all the others.

@spontanurlaub
Copy link
Collaborator

It's a bit of a mixture between an endpoint and the /bot or /user path part. I think having it lowercase is fine

@luckydonald
Copy link
Collaborator Author

@code1mountain
If it would be /user/login I'd be all on board with you.
Most users would expect it to be like the telegram docs do it, camelCase.
The ability for lower case has not been documented, and are not widely known or used.

@skrtdev
Copy link

skrtdev commented Jan 15, 2021

@luckydonald In the official docs of bot api is stated that all the methods names are case insensitive

@luckydonald
Copy link
Collaborator Author

@skrtdev Ah yes. Indeed. Missed that. Still, I'd rather keep it similar to the documentation's casing.

luckydonald added a commit to luckydonald-forks/tdlight-telegram-bot-api that referenced this pull request Jan 17, 2021
luckydonald added a commit to luckydonald-forks/tdlight-telegram-bot-api that referenced this pull request Jan 17, 2021
@andrew-ld
Copy link
Member

@giuseppeM99 merge?

@MarcoBuster
Copy link
Collaborator

@andrew-ld the build failed (because GitHub), I just restarted it. Wait until it's completed.

@MarcoBuster MarcoBuster added this to In progress in TDLight bot api via automation Jan 23, 2021
@andrew-ld andrew-ld merged commit 9df6dd5 into tdlight-team:master Jan 23, 2021
TDLight bot api automation moved this from In progress to Done Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants