Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of Hero Image (Responsive) #162

Closed
erynrat opened this issue Nov 5, 2019 · 7 comments
Closed

Styling of Hero Image (Responsive) #162

erynrat opened this issue Nov 5, 2019 · 7 comments
Labels
good first issue Good for newcomers Mobile An issue in mobile viewing styling Styling task (scss)

Comments

@erynrat
Copy link

erynrat commented Nov 5, 2019

Can someone make these style edits to the hero image and text on the homepage?

Large Laptop (1440px wide):

  • Move hero image down so pencil tips aren't so close to white nav bar
  • What is the next size down from the current text "Funding Teachers. Empowering Students."? This is looking a little big to me, but if it is a big jump down I will reconsider.
  • Can you made the tagline below bolder so it is a little more readable. Here is my original design:
    image

Smaller Laptop (1024px wide):

  • Move hero image down so pencil tips aren't beneath white nav bar
  • Header and tagline jump too far to the left when going from 1440px wide to 1024px wide. I'm hoping these basically look the same (more like 1440px wide) but with less left and right margin.

Tablet (768px wide):
So the tablet needs a good amount of help. :)
Here is a screenshot of how I want it to be upon load:
image

Here is how it is currently:
image

Changes:

  • Make hero image go down to fold on tablet on first load
  • Pencils should still be visible with pencil tips under the logo but not under the nav bar
  • Header and tagline shift down and below the pencils, slightly smaller than desktop size (what are the text size standards and I can update my design if need be?)

Mobile (425px wide and below):

  • Move hero image down and to the left so pencil tips are visible and below the logo
  • Move text down so not overlapping pencils
  • Give more margin on left of text
  • Increase line height in both the header and tagline

Here is my design:
image

Here is the current site:
image

Any questions, let me know!

@jkimexploring
Copy link
Contributor

I can work on this!

@erynrat
Copy link
Author

erynrat commented Nov 5, 2019

Thank you, Jenna! Let me know if you have any questions and I'll try to answer.

@joelwass joelwass added good first issue Good for newcomers Mobile An issue in mobile viewing styling Styling task (scss) labels Nov 5, 2019
@jkimexploring
Copy link
Contributor

So I've been trying to figure out if there'd be an easier/ less intrusive way to solve the space issue between the navigational part and the pencil tips and I think a lot of it could be solved if the image and text were in their own component. Are you cool with that or do you see a different way?

@joelwass
Copy link
Member

I think that works, @stripedpajamas what do you think

@stripedpajamas
Copy link
Member

For sure

@Jay-Topher
Copy link

Hi, has this issue been resolved? I would like to work on it.

@joelwass
Copy link
Member

joelwass commented Mar 6, 2020

Hi Jay! It actually has - sorry i didn't close it. A PR was submit about a week ago.

Take a look at our other issues and see if any interest you!

@joelwass joelwass closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Mobile An issue in mobile viewing styling Styling task (scss)
Projects
None yet
Development

No branches or pull requests

5 participants