Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make two item switcher button text vertically centered #81

Closed
joelwass opened this issue May 3, 2019 · 5 comments
Closed

Make two item switcher button text vertically centered #81

joelwass opened this issue May 3, 2019 · 5 comments
Labels
good first issue Good for newcomers styling Styling task (scss)

Comments

@joelwass
Copy link
Member

joelwass commented May 3, 2019

Center vertically the two item switcher text

code in: twoItemSwitcher.js
screenshot of bug:
Screen Shot 2019-05-03 at 2 48 26 PM
@joelwass joelwass added good first issue Good for newcomers styling Styling task (scss) labels May 3, 2019
@joelwass
Copy link
Member Author

joelwass commented May 3, 2019

All style bugs, such as this one, should use the taychon library

http://tachyons.io/docs/

@thischrisblack
Copy link
Contributor

If my recent PR for the stripe input meets your needs, I'd love to work on this one as well. Let me know, and thanks!

@joelwass
Copy link
Member Author

joelwass commented May 5, 2019

Absolutely! Thanks @thischrisblack !

@thischrisblack thischrisblack mentioned this issue May 5, 2019
Merged
@thischrisblack
Copy link
Contributor

@joelwass, I just submitted PR. It says "This branch has conflicts that must be resolved," so I'm wondering if I skipped a step? I checked the upstream master before working and it said I was up to date, so please let me know if there's a problem I can fix. Thanks!

@joelwass
Copy link
Member Author

joelwass commented May 6, 2019

fixed in above PR

@joelwass joelwass closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers styling Styling task (scss)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelwass @thischrisblack