Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript issues in v0.11.0 #96

Closed
filoozom opened this issue Sep 2, 2022 · 1 comment
Closed

TypeScript issues in v0.11.0 #96

filoozom opened this issue Sep 2, 2022 · 1 comment
Assignees
@danielart @aralroca

Comments

@filoozom
Copy link
Contributor

filoozom commented Sep 2, 2022

What version of this package are you using?

v0.11.0

What operating system, Node.js, and npm version?

Doesn't matter

What happened?

I guess it's mostly that the types in package.json points to an inexistant file, or maybe we're missing a build step somewhere?

This makes it so the library can't be used with TypeScript anymore. Build logs. https://github.com/swarmcity/boardwalk-ts/runs/8153017105?check_suite_focus=true

What did you expect to happen?

The library should correctly export its types and potentially run a build step before publishing?

Are you willing to submit a pull request to fix this bug?

Sure.
@filoozom filoozom mentioned this issue Sep 12, 2022
Open
@aralroca
Copy link
Collaborator

@filoozom fix it in 0.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielart danielart

@aralroca aralroca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielart @filoozom @aralroca