Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for gcc visibility stuff #44

Closed
malaterre opened this issue Jan 4, 2019 · 2 comments
Closed

Add support for gcc visibility stuff #44

malaterre opened this issue Jan 4, 2019 · 2 comments
Labels
enhancement
Milestone
2.1.0

Comments

@malaterre
Copy link
Contributor

Here is one patch that we maintain within Debian:

https://salsa.debian.org/med-team/charls/blob/master/debian/patches/add_visibility.patch

Would be nice to handle upstream directly. Thanks
@malaterre malaterre mentioned this issue Jan 4, 2019
Closed
@vbaderks
Copy link
Contributor

vbaderks commented Jan 4, 2019

Hi,

With commit 6fdf089 the file api_abi.h was added. This file introduces the macro:

CHARLS_API_IMPORT_EXPORT __attribute__((visibility("default")))

when the build target is a shared library for Linux.

@vbaderks vbaderks added this to the 2.1.0 milestone Jan 4, 2019
@vbaderks
Copy link
Contributor

Hi @malaterre,

I assume that the provided solution works for your problem, if not please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@malaterre @vbaderks