[doc] analysis tutorial #249
Conversation
|
Maybe it could pay off to delete your fork and re-create it? Since it's from a time before GitHub Actions existed that might mess with it. I'll review this as soon as I can. |
doc/tutorial/analysis.rst
Outdated
| .. ipython:: python | ||
| :suppress: | ||
|
|
||
| ds.xt.attrs["long_name"] = "longitude" | ||
| ds.xt.attrs["units"] = "deg" | ||
| ds.yt.attrs["long_name"] = "latitude" | ||
| ds.yt.attrs["units"] = "deg" | ||
| ds.zt.attrs["long_name"] = "depth" | ||
| ds.zt.attrs["units"] = "m" | ||
|
|
||
| .. ipython:: python | ||
|
|
||
| ds.xu.attrs["long_name"] = "longitude" | ||
| ds.xu.attrs["units"] = "deg" | ||
| ds.yu.attrs["long_name"] = "latitude" | ||
| ds.yu.attrs["units"] = "deg" |
There was a problem hiding this comment.
Why do you do this? It works fine for me if I remove this. OK I see the problem. You used nco on the output files which injected some strings that are messing up the parsing. This looks like a bug in h5netcdf to me. I will investigate this.
There was a problem hiding this comment.
Opened an issue here: h5netcdf/h5netcdf#116
There was a problem hiding this comment.
Let's use the netcdf4 engine for this tutorial instead. All you should need to do is add netcdf4 to the requirements (it's used by default in xarray). Then you don't need to touch the attributes, and you can decode times.
There was a problem hiding this comment.
I will do.
However, I would keep decode_times=False, since the decoded time has unit of ns, which is kind of pointless for time span of a year.
There was a problem hiding this comment.
There are many ways to skin a cat, and your way definitely works, I just feel that since this is an "official" tutorial we should promote best practices when working with xarray. So I changed it to what is recommended in the xarray docs.
change intro text Co-authored-by: Dion Häfner <mail@dionhaefner.de>
wip Co-authored-by: Dion Häfner <mail@dionhaefner.de>
wip Co-authored-by: Dion Häfner <mail@dionhaefner.de>
wip Co-authored-by: Dion Häfner <mail@dionhaefner.de>
change path to OUTPUT_FILES Co-authored-by: Dion Häfner <mail@dionhaefner.de>
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 82.34% 82.34%
=======================================
Files 84 84
Lines 7257 7257
Branches 875 875
=======================================
Hits 5976 5976
Misses 984 984
Partials 297 297 Continue to review full report at Codecov.
|
|
What do you think of this? I applied some xarray best practices, switched the colormaps to cmocean, and made it a bit more reproducible by describing how to get the data. |
|
It looks great! Thank you! |
|
And we're live. Thanks! |
Hi Dion,
I don't know why but Actions on my account don't currently work (trying to get in touch with GitHub support). Could you please review my commit for docs? I will probably do development in team-ocean next time (not sure it is going to help though 🤨) Sorry!
There are several hidden changes in attributes of coordinates. They are done to eliminate some problems related to textwrap module, which cannot handle the default attribute names from netCDF files 🤷♂️