fixed bug in android 4.1.1 (team-supercharge/ShimmerLayout#66). #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I read the link you have attached. It is really interesting that it happens only at API level 16, and not below or above. I still investigate this, but if I do not find another solution, your pull request will be accepted. |
|
So is there any other way to fix this issue? |
|
@chichkanov Just checked yesterday. Your solution will be great. One thing, could you move the enableForcedSoftwareLayerIfNeeded() method before the start animation call? Now it is called after that |
|
@veghtomi Probably you wanted to write to me. Well, I fixed the PR after your comment. |
|
@gali-azat96 Thank you very much for your remark and the quick fix as well!! I plan to have it released by the end of November. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in ShimmerLayout is used ComposeShader, which contains bug in android 4.1.1 with layer hardware acceleration: https://stackoverflow.com/questions/12445583/issue-with-composeshader-on-android-4-1-1