Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes samples start playing but immediately stop #47

Closed
villermen opened this issue Jun 8, 2016 · 3 comments
Closed

Sometimes samples start playing but immediately stop #47

villermen opened this issue Jun 8, 2016 · 3 comments
Assignees
@villermen
Labels
bug

Comments

@villermen
Copy link
Member

On both mobile and desktop, and happens arbitrarily. Once in every like 10 tries or so. Does not happen to samples that have already been played, even the once that had this bug occur to. So second click will always play, regardless of whether it errored before. Makes me think it is a howler bug (on 2.0.0-beta14), also happened on beta13.
@villermen villermen added the bug label Jun 8, 2016
@villermen villermen mentioned this issue Jun 8, 2016
Closed
@villermen
Copy link
Member Author

Seems to happen mainly on longer samples.

@villermen
Copy link
Member Author

villermen commented Jun 8, 2016 •
edited

onStop event is emitted when sample is loaded (why though?), which clears the sample from the list of samples that are supposed to be playing. For bigger samples this can lead into the sample cutting off after it has begun playing (not in the latest commit, as I've updated a check for that). Now instead it won't even start playing. Turns out that's also not desired.

@villermen
Copy link
Member Author

Fixed in 2d45465.

@villermen villermen self-assigned this Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@villermen villermen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@villermen