Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Some) Redmine mail headers are suppressed with plugin active #6

Closed
MegaphoneJon opened this issue Nov 28, 2017 · 3 comments
Closed

Comments

@MegaphoneJon
Copy link

In app/models/mailer.rb, the issue_add and issue_edit methods call the redmine_headers method. With this plugin installed, headers added by the redmine_headers method don't appear on the emails.

I'm not a Ruby person, so I can't tell if that's because issue_add/issue_edit are never called, or their return values are overwritten, but it seems like a bug?

To replicate:

  • Create a new issue in Redmine without the plugin installed. View the notification email's headers; they include an "X-Redmine-Project" header.
  • Install the plugin and create another issue. The notification email's headers no longer include the "X-Redmine-Project" header.
@hhokawa777
Copy link
Member

yes, you are right. thank you.
this plugin clear headers after calling issue_add (calling is done by so called monkey-patch: alias_method_chain).
sorry cant fix immediately due to sick these days but solution would be copy redmine_headers lines just before every mail to: .. calls in plugin lib code.

@hhokawa777
Copy link
Member

the solution for your reported issue is released as v0.9.0 with other funcitionalities. thanks.

@MegaphoneJon
Copy link
Author

I finally had a chance to test this - I was running with a patched version so I had no urgency, but I wanted to report back. This new version works great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants