Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a go.mod file #21

Closed
srikrsna opened this issue Nov 15, 2018 · 6 comments
Closed

Add a go.mod file #21

srikrsna opened this issue Nov 15, 2018 · 6 comments

Comments

@srikrsna
Copy link
Contributor

It will be nice to have a go.mod file.
@srikrsna
Copy link
Contributor Author

Any thoughts on this?

@zensh
Copy link
Contributor

zensh commented Nov 29, 2018 •
edited
Loading

go.mod is every nice, but there is no external dependence in rrule-go

@srikrsna
Copy link
Contributor Author

go.mod is not just for external dependencies. It can at least be used to work outside GOPATH and a good way to future proof where go.mod will be requirement.

@zensh
Copy link
Contributor

zensh commented Nov 29, 2018

@srikrsna That is good

@srikrsna
Copy link
Contributor Author

Shall I send a PR?

@zensh
Copy link
Contributor

zensh commented Nov 29, 2018

@srikrsna It is welcome

@srikrsna srikrsna mentioned this issue Nov 29, 2018
Merged
@zensh zensh closed this as completed Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zensh @srikrsna