Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ritual of Eldritch Will help&bug #77

Closed
Sandman366 opened this issue Dec 5, 2019 · 3 comments
Closed

Ritual of Eldritch Will help&bug #77

Sandman366 opened this issue Dec 5, 2019 · 3 comments
Assignees
Labels

Comments

@Sandman366
Copy link

Trying to understand how to use Ritual of Eldritch Will (because the CurseForge page doesn't say much and I can't find any other documentation). I think I've figured it out: just setup the ritual and it exports into Will Aura, right? Or does it need something else? (And it's just so super insanely slow that the only time I've seen it work so far is breaking MRS and activating again? What unit is "speed" in, anyway? Minutes?)

While trying to figure it out, I did find another issue: the runes. It only places 16, but says it needs 17...looks like it's short a dusk rune. (Which it seems to say the ritual works just fine without, which also confused me 'til I tried glancing at source.)

Don't know how to suggest edits directly so I'll just put it here:
src/main/java/com/teamdman/animus/rituals/RitualEldritchWill.java
Lines 124 and 125 are duplicates, one of them needs to be BlockPos(-3, 1, -3).

(Also on yet another thing at looking at the source for the ritual....maybe I just don't know how to read this, but to me it looks like it checks if Thaumcraft is loaded, and if it is, then "refreshTime" is 10,000, and if it's not, then use config time to refresh ritual. Similar story for "refreshCost", except that goes to 0 instead of config.)

@Saereth
Copy link
Collaborator

Saereth commented Dec 5, 2019

I'll do some testing and fix this up today. oddly enough its working for me in all the mods expert 3 shedding tiers pack atm. The duplicate rune is definitely a mistake but weird that it runs without it. The refresh time is just a reversed boolean.

The refresh time is in ticks so (20/s) if the server isnt lagging. Expect a new jar with the fixes on curseforge this evening,

I may even get a chance to add in the configurable radius for the ritual as well.

@Saereth Saereth added the bug label Dec 5, 2019
@Sandman366
Copy link
Author

Does actually work without repeatedly restarting the ritual, just didn't see it at the time, so it's just a duplicate rune placement check and really slow. (And also didn't at first realize it went into Will Aura, for some reason I expected Will items.)

@Saereth
Copy link
Collaborator

Saereth commented Dec 6, 2019

resolved in 97798ba

Also updated the curseforge page to better explain that it's creating demon will aura and not the items.

@Saereth Saereth closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants