Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#412 added handling of nicks in author tag #496

Merged
merged 4 commits into from Nov 26, 2015
Merged

#412 added handling of nicks in author tag #496

merged 4 commits into from Nov 26, 2015

Conversation

krzyk
Copy link
Collaborator

@krzyk krzyk commented Nov 16, 2015

#412

  • recreated problem in unit test
  • changed number of words required in the author name to 1

@krzyk krzyk mentioned this pull request Nov 16, 2015
Closed
@davvd
Copy link

davvd commented Nov 17, 2015

@krzyk Thanks, I will find someone to review this PR soon

@davvd
Copy link

davvd commented Nov 18, 2015

@yegor256 this pull request is for you,please review

@davvd davvd added the CR label Nov 18, 2015
@davvd davvd added the 15 mins label Nov 18, 2015
@krzyk
Copy link
Collaborator Author

krzyk commented Nov 19, 2015

@yegor256 I've updated the code (now it works correctly on travis)

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 22, 2015

@yegor256 ping

@yegor256
Copy link
Owner

@rultor try to merge

@rultor
Copy link
Collaborator

rultor commented Nov 22, 2015

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Nov 22, 2015

@rultor try to merge

@krzyk @yegor256 Oops, I failed. You can see the full log here (spent 9min)

[ERROR] *  codenarc-violations/pom.xml
[INFO] -------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] qulice ............................................ SUCCESS [  7.944 s]
[INFO] qulice-spi ........................................ SUCCESS [ 12.545 s]
[INFO] qulice-checkstyle ................................. SUCCESS [ 25.656 s]
[INFO] qulice-pmd ........................................ SUCCESS [ 18.140 s]
[INFO] qulice-codenarc ................................... SUCCESS [ 16.667 s]
[INFO] qulice-findbugs ................................... SUCCESS [ 24.453 s]
[INFO] qulice-xml ........................................ SUCCESS [ 10.870 s]
[INFO] qulice-ant ........................................ SUCCESS [ 28.267 s]
[INFO] qulice-maven-plugin ............................... FAILURE [04:12 min]
[INFO] qulice-gradle-plugin .............................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 06:38 min
[INFO] Finished at: 2015-11-22T18:32:15+00:00
[INFO] Final Memory: 133M/526M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:1.6:run (default) on project qulice-maven-plugin: 1 build failed. See console output above for details. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-invoker-plugin:1.6:run (default) on project qulice-maven-plugin: 1 build failed. See console output above for details.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: 1 build failed. See console output above for details.
    at org.apache.maven.plugin.invoker.InvokerSession.handleFailures(InvokerSession.java:258)
    at org.apache.maven.plugin.invoker.InvokerMojo.processResults(InvokerMojo.java:59)
    at org.apache.maven.plugin.invoker.AbstractInvokerMojo.execute(AbstractInvokerMojo.java:692)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :qulice-maven-plugin

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 22, 2015

@yegor256 please try again, there was a problem with connection to maven central

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 25, 2015

@yegor256 ping

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Nov 26, 2015

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit e893b7c into yegor256:master Nov 26, 2015
@rultor
Copy link
Collaborator

rultor commented Nov 26, 2015

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 16min)

@davvd
Copy link

davvd commented Nov 30, 2015

@yegor256 thank you, added 17 mins to your acc, payment num is 000-7ba277f5, 195 hours and 45 mins spent in total to complete

review comments (c=2) added as a bonus

+17 added to your rating, at the moment it is: +9392

@davvd
Copy link

davvd commented Nov 30, 2015

@rultor deploy

@rultor
Copy link
Collaborator

rultor commented Nov 30, 2015

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 30, 2015

@rultor deploy

@davvd Done! FYI, the full log is here (took me 13min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yegor256 yegor256

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krzyk @davvd @yegor256 @rultor