Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qulice-checkstyle: failure on pom.xml with continuation indent != 2 is required #940

Open
dgroup opened this issue Nov 18, 2018 · 2 comments
Open

qulice-checkstyle: failure on pom.xml with continuation indent != 2 is required #940

dgroup opened this issue Nov 18, 2018 · 2 comments

Comments

@dgroup
Copy link
Contributor

dgroup commented Nov 18, 2018

For now, qulice-checkstyle allows the pom.xml(s) with continuation indent equal to 4, like in *.java files

<plugins>
    <plugin>
        <artifactId>maven-compiler-plugin</artifactId>
        <configuration>
            <source>8</source>
            <target>8</target>
        </configuration>
    </plugin>
    <plugin>
        <artifactId>maven-jar-plugin</artifactId>
        <configuration>
            <archive>
                <manifestEntries>
                    <Qulice-Version>${project.version}</Qulice-Version>
                    <Qulice-Build>${buildNumber}</Qulice-Build>
                </manifestEntries>
            </archive>
        </configuration>
    </plugin>
    <plugin>
        <artifactId>maven-javadoc-plugin</artifactId>
        <version>3.0.0</version>
        <configuration>
            <tags>
                <tag>
                    <name>todo</name>
                    <placement>a</placement>
                    <head>todo:</head>
                </tag>
                <tag>
                    <name>checkstyle</name>
                    <placement>a</placement>
                    <head>checkstyle:</head>
                </tag>
            </tags>
        </configuration>
    </plugin>
</plugins>

however with indent = 2 the content became more compact

<plugins>
  <plugin>
    <artifactId>maven-compiler-plugin</artifactId>
    <configuration>
      <source>8</source>
      <target>8</target>
    </configuration>
  </plugin>
  <plugin>
    <artifactId>maven-jar-plugin</artifactId>
    <configuration>
      <archive>
        <manifestEntries>
          <Qulice-Version>${project.version}</Qulice-Version>
          <Qulice-Build>${buildNumber}</Qulice-Build>
        </manifestEntries>
      </archive>
    </configuration>
  </plugin>
  <plugin>
    <artifactId>maven-javadoc-plugin</artifactId>
    <version>3.0.0</version>
    <configuration>
      <tags>
        <tag>
          <name>todo</name>
          <placement>a</placement>
          <head>todo:</head>
        </tag>
        <tag>
          <name>checkstyle</name>
          <placement>a</placement>
          <head>checkstyle:</head>
        </tag>
      </tags>
    </configuration>
  </plugin>
</plugins>

The new qulice rule will help to have all pom.xml(s) in the same compact format.
@0crat
Copy link
Collaborator

0crat commented Nov 18, 2018

@krzyk/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Nov 18, 2018

@dgroup/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@dgroup dgroup changed the title qulice-checkstyle: pom.xml with continuation indent != 2 qulice-checkstyle: failure on pom.xml with continuation indent != 2 is required Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgroup @0crat