Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #1004: Enforce since tag in inner classes #1013

Merged
merged 1 commit into from Jan 30, 2019

Conversation

paulodamaso
Copy link
Contributor

For #1004: Enforce since tag in inner classes

  • Corrected JavadocTagsCheck.java
  • Added check execution to tests and validation
  • Corrected sample classes for other tests

@0crat 0crat added the scope label Jan 27, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 27, 2019

Job #1013 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jan 27, 2019

This pull request #1013 is assigned to @paulodamaso/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @krzyk/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@paulodamaso
Copy link
Contributor Author

@krzyk PLease take a look, 0crat assigned me my own pull request

@paulodamaso
Copy link
Contributor Author

@krzyk ping

@krzyk
Copy link
Collaborator

krzyk commented Jan 30, 2019

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 30, 2019

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 742f4bc into yegor256:master Jan 30, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 30, 2019

@rultor merge

@krzyk Done! FYI, the full log is here (took me 19min)

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

@ypshenychka/z please review this job completed by @paulodamaso/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jan 30, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

The job #1013 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @krzyk/z

@ypshenychka
Copy link

@0crat quality bad

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

Quality is low, no payment, see §31

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

@0crat quality bad (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 30, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@paulodamaso paulodamaso deleted the 1004 branch January 30, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants