Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #1019: Upgraded all projects except maven-qulice-plugin to Junit5. #1027

Merged
merged 2 commits into from Feb 8, 2019

Conversation

paulodamaso
Copy link
Contributor

For #1019:

  • Upgraded all projects except maven-qulice-plugin to Junit5.
  • Left puzzle in maven-qulice-plugin to upgrade it to Junit5.

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2019

Job #1027 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Feb 7, 2019

@krzyk/z everybody who has role REV is banned at #1027; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator

krzyk commented Feb 7, 2019

@paulodamaso there is one checkstyle issue:

Checkstyle: qulice-findbugs/src/test/java/com/qulice/findbugs/FindBugsValidatorTest.java[85]: Empty line inside method (EmptyLinesCheck)

@krzyk
Copy link
Collaborator

krzyk commented Feb 8, 2019

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 8, 2019

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7a7a429 into yegor256:master Feb 8, 2019
@rultor
Copy link
Collaborator

rultor commented Feb 8, 2019

@rultor merge

@krzyk Done! FYI, the full log is here (took me 20min)

@0crat 0crat removed the scope label Feb 8, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 8, 2019

Job gh:teamed/qulice#1027 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Feb 8, 2019

The job #1027 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants