Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #982: Disable CallSuperInConstructor check #1028

Merged
merged 3 commits into from Feb 9, 2019

Conversation

paulodamaso
Copy link
Contributor

For #982:

  • Disabled CallSuperInConstructor check
  • Added test to check if CallSuperInConstructor is disabled

@0crat 0crat added the scope label Feb 8, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 8, 2019

Job #1028 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Feb 8, 2019

@krzyk/z everybody who has role REV is banned at #1028; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator

krzyk commented Feb 8, 2019

@paulodamaso please add also a test that shows that qulice fails when there is a super() in in constructor

@paulodamaso
Copy link
Contributor Author

@krzyk I did not understood that way, I thought that it wouldn't fail if there is no super() in constructor.

@krzyk
Copy link
Collaborator

krzyk commented Feb 9, 2019

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 9, 2019

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 8dfb711 into yegor256:master Feb 9, 2019
@rultor
Copy link
Collaborator

rultor commented Feb 9, 2019

@rultor merge

@krzyk Done! FYI, the full log is here (took me 19min)

@0crat 0crat removed the scope label Feb 9, 2019
@0crat
Copy link
Collaborator

0crat commented Feb 9, 2019

Job gh:teamed/qulice#1028 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Feb 9, 2019

The job #1028 is now out of scope

@paulodamaso paulodamaso deleted the 982 branch February 10, 2019 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants