Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For #1034: Fix IndexOutOfBoundsException in JavadocParameterOrderCheck #1038

Merged
merged 2 commits into from Apr 25, 2019
Merged

For #1034: Fix IndexOutOfBoundsException in JavadocParameterOrderCheck #1038

merged 2 commits into from Apr 25, 2019

Conversation

zCRUSADERz
Copy link
Contributor

@zCRUSADERz zCRUSADERz commented Apr 23, 2019

Fix IndexOutOfBoundsException occurs when number of @param tags is less then number of actual parameters.

See #1034

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

@krzyk/z please, pay attention to this pull request

@0crat 0crat added the scope label Apr 23, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

Job #1038 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Apr 23, 2019

@krzyk/z everybody who has role REV is banned at #1038; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@krzyk
Copy link
Collaborator

krzyk commented Apr 25, 2019

@zCRUSADERz Thanks

@krzyk
Copy link
Collaborator

krzyk commented Apr 25, 2019

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Apr 25, 2019

@rultor merge

@krzyk OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cd1e2c9 into yegor256:master Apr 25, 2019
@rultor
Copy link
Collaborator

rultor commented Apr 25, 2019

@rultor merge

@krzyk Done! FYI, the full log is here (took me 24min)

@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

Job gh:teamed/qulice#1038 is not assigned, can't get performer

@0crat 0crat removed the scope label Apr 25, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 25, 2019

The job #1038 is now out of scope

@zCRUSADERz zCRUSADERz deleted the fix-parameter-order-check branch April 26, 2019 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants