Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import users: JSON schema not accurate #1198

Closed
2 tasks done
lfleischmann opened this issue Nov 15, 2023 · 0 comments · Fixed by #1202
Closed
2 tasks done

import users: JSON schema not accurate #1198

lfleischmann opened this issue Nov 15, 2023 · 0 comments · Fixed by #1202
Labels
bug Something isn't working

Comments

@lfleischmann
Copy link
Member

lfleischmann commented Nov 15, 2023

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Describe the bug

The JSON schema for the user import file is not accurate. Certain fields/properties are marked as required but should be optional.

Reproducing the bug

  1. Create a JSON file. Add contents according to the schema in backend/json_schema/hanko.user_import.json. Try to omit fields that are currently required but should be optional as suggested by code comments, e.g. user_id or created_at/updated_at for an ImportEntry:
[
  {
    "emails": [],
  }
]
  1. Validate the file using the schema by associating with the backend/json_schema/hanko.user_import.json schema in your IDE or use different validator.

Logs

No response

Configuration

No response

Hanko Version

d5f0bb0

OS Hanko Backend

None

OS Version Hanko Backend

No response

OS

None

OS Version

No response

Browser Version

No response

Environment

None

Additional Context

No response

@lfleischmann lfleischmann added the bug Something isn't working label Nov 15, 2023
@lfleischmann lfleischmann changed the title Import users: JSON schema not accurate import users: JSON schema not accurate Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant