Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make e2e test check for component ids instead of button texts etc. #203

Open
FlxMgdnz opened this issue Aug 30, 2022 · 1 comment
Open

Make e2e test check for component ids instead of button texts etc. #203

FlxMgdnz opened this issue Aug 30, 2022 · 1 comment
Labels
javascript Pull requests that update Javascript code tests

Comments

@FlxMgdnz
Copy link
Member

Changing e.g. a button text in hanko-auth currently breaks e2e tests because the tests are based on strings ("see if button with text 'Sign in with a passkey" appears").

Wouldn't it be better to set ids for all relevant components in the element and make the tests check for the ids?
@like-a-bause like-a-bause added javascript Pull requests that update Javascript code tests labels Sep 19, 2022
@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 29, 2023
@FlxMgdnz FlxMgdnz closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2023
@lfleischmann lfleischmann reopened this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code tests
Projects
Hanko
Status: ✅ Recently closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@like-a-bause @FlxMgdnz @lfleischmann