Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update third_party handler test #623

Closed
2 tasks done
FreddyDevelop opened this issue Mar 2, 2023 · 0 comments · Fixed by #701
Closed
2 tasks done

Update third_party handler test #623

FreddyDevelop opened this issue Mar 2, 2023 · 0 comments · Fixed by #701
Labels
enhancement New feature or request tests

Comments

@FreddyDevelop
Copy link
Contributor

Checklist

  • I could not find a solution in the existing issues or docs.
  • I agree to follow this project's Code of Conduct.

Description

Currently the test uses a test persister, which mocks the persister we use in the handler. But it does not provides all functionality to test the handler completely and it is hard to maintain.

Describe your ideal solution

Change the test, that need a database, to integration tests, using github.com/ory/dockertest. One handler test is already using it, check it out: user_test.go.

If a test needs a database, it should be skipped if the -short flag is provided. So even if someone has no docker installed, he can run some tests.

Workarounds or alternatives

No response

Hanko Version

all

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant