You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bookmark multiple youtube-generated remote playlists (e.g. found by looking for music abums using the Albums search filter)
move the local playlist and the user-created remote playlist to the top of the bookmarked playlists
for each youtube-generated remote playlist, open it then go back to the bookmarked playlists view
Expected behavior
the order of playlists should not change when the playlists are opened
Actual behavior
when opened, the youtube generated remote playlists are moved up to the top of the bookmarked playlists, above the user-created remote playlist and the local playlist, where they are ordered alphabetically among themselves
when opened, neither the local playlist nor the user-created remote playlist are sent back up to the top of the bookmarked playlists (expected behavior)
Screenshots/Screen recordings
video_2024-04-29_16-00-46.mp4
Logs
No response
Affected Android/Custom ROM version
Android 12
Affected device model
Samsung Galaxy S10
Additional information
No response
The text was updated successfully, but these errors were encountered:
reopening as a new issue from a discussion on #10993, as suggested by @opusforlife2. Here is the state of my research on the topic so far:
the getPlaylists() queries in the RemotePlaylistDAO and local playlist DAO classes seem to be ordered by display index, as expected, which lets me think that the issue is with either merge logic or the updating of display indices, but not with the queries themselves
the fact that only autogenerated remote playlists are affected is very strange and confuses me greatly
the fact that remote playlists are sorted alphabetically before all other playlists may indicate that they share the same display index
this line sets the display index to -1 for all remote playlists by default (which is strange, because newly bookmarked remote playlists do not appear at the top of the bookmarked playlists but at the bottom)
the only place in the entire codebase where setDisplayIndex() is called on a PlaylistRemoteEntity is in BookmarkFragment.saveImmediate(), which is called by BookmarkFragment.onPause() (this corresponds with the moment at which the playlists are moved all the way up)
in saveImmediate(), debounceSaver.getIsModified() returns false so the function returns immediately. The code which computes and updates the display index for playlists is not executed. it seems that the issue is with the debounceSaver in some way, but i do not understand this part of the application very well
opusforlife2
added
GUI
Issue is related to the graphical user interface
playlist
Anything to do with playlists in the app
and removed
needs triage
Issue is not yet ready for PR authors to take up
labels
Apr 29, 2024
you can consider that i working on this btw, I just won't have time in the next couple of days.
Here's a new specificity i observed about the behavior (shown in the video below): the buggy reordering is only triggered when the playlist is loaded. Once it has been loaded, opening it does not trigger the reordering
Checklist
Affected version
0.27.0
Steps to reproduce the bug
Expected behavior
the order of playlists should not change when the playlists are opened
Actual behavior
Screenshots/Screen recordings
video_2024-04-29_16-00-46.mp4
Logs
No response
Affected Android/Custom ROM version
Android 12
Affected device model
Samsung Galaxy S10
Additional information
No response
The text was updated successfully, but these errors were encountered: