You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Its quit confusing if you want to implement a service getTimeStamp is in the context of the StreamExtractor and not the upload date or something like this. It would be better to move this to the StreamUrlIdHandler because its a url parsing part and not something that is in the meta data of the stream, like the most data that is can be accessed over the StreamExtractor
or directly in the living standard implementation of url parsing that comes with DTube and MediaCCC support. (Url Parsing get maybe moved to a whole new project)
The text was updated successfully, but these errors were encountered:
FlorianSteenbuck
changed the title
[REFACTOR][NICE TO HAVE] rename timeStamp to streamTimeStamp or move to StreamUrlIdHandler
[Refactor][Nice to have] rename timeStamp to streamTimeStamp or move to StreamUrlIdHandler
Apr 29, 2018
Its quit confusing if you want to implement a service
getTimeStamp
is in the context of theStreamExtractor
and not the upload date or something like this. It would be better to move this to theStreamUrlIdHandler
because its a url parsing part and not something that is in the meta data of the stream, like the most data that is can be accessed over theStreamExtractor
++ extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamUrlIdHandler.java
or directly in the living standard implementation of url parsing that comes with DTube and MediaCCC support. (Url Parsing get maybe moved to a whole new project)
Relevent for new implementations.
And currently in the DTube Implementation (already fixed local):
Wrong Implementation
|_ Usage of Wrong Implementation
|_ Base Needs to be removed
|_ Base Needs to be removed now
The text was updated successfully, but these errors were encountered: