Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor][Nice to have] rename timeStamp to streamTimeStamp or move to StreamUrlIdHandler #80

Open
FlorianSteenbuck opened this issue Apr 29, 2018 · 1 comment

Comments

@FlorianSteenbuck
Copy link

FlorianSteenbuck commented Apr 29, 2018

Its quit confusing if you want to implement a service getTimeStamp is in the context of the StreamExtractor and not the upload date or something like this. It would be better to move this to the StreamUrlIdHandler because its a url parsing part and not something that is in the meta data of the stream, like the most data that is can be accessed over the StreamExtractor

++ extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamUrlIdHandler.java

public interface StreamUrlIdHandler extends UrlIdHandler {
String getTimeStamp(String url) throws ParsingException;
}

or directly in the living standard implementation of url parsing that comes with DTube and MediaCCC support. (Url Parsing get maybe moved to a whole new project)

Relevent for new implementations.
And currently in the DTube Implementation (already fixed local):
Wrong Implementation
|_ Usage of Wrong Implementation
|_ Base Needs to be removed
|_ Base Needs to be removed now

@FlorianSteenbuck FlorianSteenbuck changed the title [REFACTOR][NICE TO HAVE] rename timeStamp to streamTimeStamp or move to StreamUrlIdHandler [Refactor][Nice to have] rename timeStamp to streamTimeStamp or move to StreamUrlIdHandler Apr 29, 2018
@theScrabi
Copy link
Member

Can you please link the relevant code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants