Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/24 server export functionality #91

Merged
merged 7 commits into from Sep 20, 2021
Merged

issue/24 server export functionality #91

merged 7 commits into from Sep 20, 2021

Conversation

treilik
Copy link
Contributor

@treilik treilik commented Sep 20, 2021

  • [issue/24] - prepared mocking of the database content
  • [issue/24] - add struct for JSON export
  • [issue/24] - improved mock data creation for test db
  • [issue/24] - renamed file for JSON export code
  • [issue/24] - add export command to cobra
  • [issue/24] - Change error handling in export command
  • [issue/24] - added verbose falg to export cmd

@treilik treilik self-assigned this Sep 20, 2021
@treilik
Copy link
Contributor Author

treilik commented Sep 20, 2021

closes #24

@treilik treilik force-pushed the issue/24-server-export-functionality branch from 48a480d to 8f764bf Compare September 20, 2021 09:28
AnnaGsell
AnnaGsell previously approved these changes Sep 20, 2021
View reviewed changes
@treilik
[issue/24] - prepared mocking of the database content
3a4d965 
for testing purposes
  - wrote simple base test WriteRead
@treilik
[issue/24] - add struct for JSON export
6a90ec1 
  - implements helper function for the JSON export struct's, which
    filles the struct with all objects that reference it.
    So a objects which is referenced by others in the database, holds in the JSON version all
    this references directly.
@treilik
[issue/24] - improved mock data creation for test db
f75301c
@treilik
[issue/24] - renamed file for JSON export code
b1c83df 
  - form db.go to export.go since its only purpose is the export of the
    database
@treilik
[issue/24] - add export command to cobra
b863c62 
  - with check if there are studies which can be exported
@treilik
[issue/24] - Change error handling in export command
6001a11
@mac641 mac641 added the enhancement New feature or request label Sep 20, 2021
@mac641 mac641 added this to the Step I milestone Sep 20, 2021
@treilik treilik force-pushed the issue/24-server-export-functionality branch from 8f764bf to 2881a64 Compare September 20, 2021 09:54
mac641
mac641 approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@mac641 mac641 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🚀

diehmlukas
diehmlukas approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@diehmlukas diehmlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!!

@treilik treilik merged commit d8e888c into main Sep 20, 2021
@treilik treilik deleted the issue/24-server-export-functionality branch September 20, 2021 09:56
@mac641 mac641 linked an issue Sep 20, 2021 that may be closed by this pull request
Implement export functionality on server side #24
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mac641 mac641 mac641 approved these changes

@diehmlukas diehmlukas diehmlukas approved these changes

@AnnaGsell AnnaGsell AnnaGsell approved these changes

Assignees

@treilik treilik

Labels
enhancement New feature or request
Projects
None yet
Milestone
Step I
Development

Successfully merging this pull request may close these issues.

Implement export functionality on server side
4 participants
@treilik @mac641 @diehmlukas @AnnaGsell