Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enum Other case to prevent breaking changes in future #5

Closed
baransu opened this issue Jul 25, 2019 · 1 comment
Closed

Add enum Other case to prevent breaking changes in future #5

baransu opened this issue Jul 25, 2019 · 1 comment
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@baransu
Copy link
Collaborator

baransu commented Jul 25, 2019 •
edited
Loading

We should mandatory generate Other case for enums.

Original issue: mhallin/graphql_ppx#69
@baransu baransu added this to the 0.2 milestone Aug 10, 2019
@baransu baransu modified the milestones: 0.2, 0.3 Sep 8, 2019
@baransu baransu mentioned this issue Sep 22, 2019
Closed
@baransu baransu removed this from the 0.3 milestone Oct 19, 2019
@baransu baransu added the enhancement New feature or request label Nov 4, 2019
@baransu baransu added this to the 1.0.0 milestone Jan 13, 2020
@baransu baransu mentioned this issue Feb 26, 2020
Closed
@jfrolich
Copy link
Collaborator

jfrolich commented Mar 15, 2020 •
edited
Loading

Discussed in discord chat to name this FutureAddedValue(string), this will also be implemented for reason-relay so the behavior will be consistent between libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@jfrolich @baransu